Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Tensorflow modules #24

Merged
merged 3 commits into from
Jan 16, 2024

Conversation

onobc
Copy link
Collaborator

@onobc onobc commented Jan 16, 2024

This commit removes the following Tensorflow 1.0 related modules:

  • spring-tensorflow-common
  • spring-image-recognition-function
  • spring-object-detection-function
  • spring-semantic-segmentation-function

These may be resurrected at a later date but re-implemented with either DeepJavaLibrary or TensorFlow 2.0.

This commit removes the following Tensorflow 1.0 related modules:

- spring-tensorflow-common
- spring-image-recognition-function
- spring-object-detection-function
- spring-semantic-segmentation-function

These may be resurrected at a later date but re-implemented with
either DeepJavaLibrary or TensorFlow 2.0.
@onobc onobc requested a review from artembilan January 16, 2024 21:29
Copy link
Collaborator

@artembilan artembilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See README.adoc in the project root for unreachable docs.
See dependencies.gradle for unused protobufJava & protobufVersion.
Also the checkFormatMain Gradle tasks is redundant now.

Thanks

@artembilan artembilan added this to the 5.0.0-M1 milestone Jan 16, 2024
@artembilan artembilan added the type: task A general task label Jan 16, 2024
Copy link
Collaborator

@artembilan artembilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Will merge when build is green.

@@ -26,78 +26,70 @@ This functions catalog is also a foundation for https://spring.io/projects/sprin
|link:supplier/spring-ftp-supplier/README.adoc[FTP]
|link:function/spring-header-enricher-function/README.adoc[Header-Enricher]
|link:consumer/spring-elasticsearch-consumer/README.adoc[Elasticsearch]
|
|link:function/spring-header-filter-function/README.adoc[Header-Filter]
|link:consumer/spring-file-consumer/README.adoc[File]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also removed the sparse spacing as the attempt to line up "like" supplier/function/consumer was a bit chaotic and was not lined up. Now they are just alpha ordered each column.

Screen Shot 2024-01-16 at 16 01 23

@artembilan artembilan merged commit 0f65110 into spring-cloud:main Jan 16, 2024
3 checks passed
@onobc onobc deleted the cbono-remove-tensorflow branch January 16, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants